Skip to content

Check if a town can bypass the adjacent chunk check per-world - #8290

Open
Veyronity wants to merge 1 commit into
TownyAdvanced:masterfrom
Veyronity:feat/proximity-util-per-world-exception
Open

Check if a town can bypass the adjacent chunk check per-world#8290
Veyronity wants to merge 1 commit into
TownyAdvanced:masterfrom
Veyronity:feat/proximity-util-per-world-exception

Conversation

@Veyronity

@Veyronity Veyronity commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description:

This updates the ProximityUtil check for if a town is large enough to enforce adjacent chunk rules, to keep in mind the TownyWorld the check is happening for


Attestations

  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

In making this pull request, I declare that I have not used an AI toolset to design or code this pull request, and that I am a human who coded this without any influence from an LLM.

@LlmDl

LlmDl commented Sep 2, 2026

Copy link
Copy Markdown
Member

I think this looks correct, can you tell me which ways this has been tested?

ie:

  • claimed a town following the rules with adjacency enabled.
  • claimed an outpost in a world where they already have their town.
  • claimed an outpost in a world where they dont already have their town.
  • attempted to claim a 2nd outpost.

@Veyronity

Copy link
Copy Markdown
Contributor Author
  • The goal, allowing the claiming of a 5th chunk after a 2x2 on the new world, has been accomplished
  • expansion is still prevented after 5 chunks in the target world if it doesn't follow the min adjacent requirement
  • successfully claimed an outpost in a new world, expanded as mentioned above
  • successfully claimed a second outpost in the same world, rules of adjacency still limit expansion (The outpost adjacent exception still works)

@LlmDl

LlmDl commented Sep 3, 2026

Copy link
Copy Markdown
Member

I think that claiming a outpost in a world you've already got claims in should be blocked, as those claims are not adjacent to the town in that world. Making a second outpost in that same world should also get blocked.

I believe outposts should only be allowed in other worlds, and be limited to one per world, otherwise the adjacent claims feature is effectively bypassed.

@Veyronity

Copy link
Copy Markdown
Contributor Author

This PR doesn't interfere that behavior, even as of now players can claim multiple outposts in the same world.
If you'd like me to add it, I will do so, but I believe some towny admins may not like that. Outposts aren't always to expand to new worlds (in my case it is though)

@LlmDl

LlmDl commented Sep 3, 2026

Copy link
Copy Markdown
Member

I think it ought to be blocked, when I made it possible to make an outpost I must have not taken that into account.

Whether a town is allowed to make an outpost in a world they already have claims in could get added as a config option I guess.

@Veyronity

Copy link
Copy Markdown
Contributor Author

I can make a separate PR for that to help out if you'd like
Any other comments about this one?

@LlmDl

LlmDl commented Sep 3, 2026

Copy link
Copy Markdown
Member

I'm happy with this one as it stands now. I think adjacent claiming rules should be per-world.

You could make a new PR for the other thing or put it into this PR, either is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants